Remove register details #172
Merged
+58
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer has warnings in the QA report. It's still worth highlighting that the underlying IG may change.
Remove the register type and register specifier info from Provenance.entity, as we weren't able to reach consensus on whether it should be there or somewhere else. Still leave the removed parts visible in comments, so that it is easier to refer to them when the work continues in the future.
|
For review, only the most recent commits, starting from b0e966a are applicable. Other changes are from previous pull requests that are still waiting to be merged. |
mikajylha
approved these changes
Oct 26, 2023
teropekkola
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the register type and register specifier info from Provenance.entity, as we weren't able to reach consensus on whether it should be there or somewhere else.
Let's still leave the removed parts visible in comments, so that it is easier to refer to them when the work continues in the future.